fix: read iam client id and secret from environment variables #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 93.28% 93.35% +0.07%
==========================================
Files 12 12
Lines 506 512 +6
Branches 147 151 +4
==========================================
+ Hits 472 478 +6
Misses 33 33
Partials 1 1
Continue to review full report at Codecov.
|
ibm-devx-automation
pushed a commit
that referenced
this pull request
Jun 23, 2019
## [0.3.2](v0.3.1...v0.3.2) (2019-06-23) ### Bug Fixes * read iam client id and secret from environment variables ([#30](#30)) ([2247d0a](2247d0a))
|
🎉 This PR is included in version 0.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the IAM Client ID and Secret parameters were added, I forgot to include them in the
getServiceCredentialsandgetCredentialsFromEnvironmentmethods. They should be included here so they can be specified as environment variables like any other credential parameter.