Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add deprecation notice for node versions 6 and 8 #32

Merged
merged 3 commits into from
Jul 17, 2019

Conversation

dpopp07
Copy link
Member

@dpopp07 dpopp07 commented Jul 17, 2019

Marking support for Node versions 6 and 8 as deprecated. Added a notice in the README. Also added a check in the code that will print a warning to the console if the user is using one of the deprecated versions.

Also updating the Travis build config to disable caching, as Travis started caching automatically in July 2019 and this can break repositories using semantic-release.

@codecov
Copy link

codecov bot commented Jul 17, 2019

Codecov Report

Merging #32 into master will decrease coverage by 0.29%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #32     +/-   ##
=========================================
- Coverage   93.35%   93.06%   -0.3%     
=========================================
  Files          12       12             
  Lines         512      519      +7     
  Branches      151      153      +2     
=========================================
+ Hits          478      483      +5     
- Misses         33       35      +2     
  Partials        1        1
Impacted Files Coverage Δ
lib/base_service.ts 91.66% <71.42%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8291285...4b879ef. Read the comment docs.

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I'm not a node.js expert by any means, but this seems fit for purpose :)

@dpopp07 dpopp07 merged commit 9e3c667 into master Jul 17, 2019
@dpopp07 dpopp07 deleted the deprecate-node-6-and-8 branch July 17, 2019 21:32
ibm-devx-automation pushed a commit that referenced this pull request Jul 17, 2019
## [0.3.3](v0.3.2...v0.3.3) (2019-07-17)

### Bug Fixes

* add deprecation notice for node versions 6 and 8 ([#32](#32)) ([9e3c667](9e3c667))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants