fix: share service request wrapper instance with token managers #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will allow users to configure all requests, rather than just the service requests this was causing a bug where users could not use the SDK behind a corporate proxy
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
=======================================
Coverage 93.06% 93.06%
=======================================
Files 12 12
Lines 519 519
Branches 154 155 +1
=======================================
Hits 483 483
Misses 35 35
Partials 1 1
Continue to review full report at Codecov.
|
germanattanasio
approved these changes
Aug 7, 2019
ibm-devx-automation
pushed a commit
that referenced
this pull request
Aug 7, 2019
## [0.3.5](v0.3.4...v0.3.5) (2019-08-07) ### Bug Fixes * share service request wrapper instance with token managers ([#36](#36)) ([e7609e2](e7609e2))
|
🎉 This PR is included in version 0.3.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow users to configure all requests, rather than just the service requests. This was causing a bug where users could not use the SDK behind a corporate proxy. They could specify the proxy for the service request but the IAM request would error.