fix: Move check for serviceUrl to createRequest #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release-v1-rc2 #47 +/- ##
==================================================
+ Coverage 95.82% 95.95% +0.13%
==================================================
Files 23 23
Lines 575 594 +19
Branches 121 133 +12
==================================================
+ Hits 551 570 +19
Misses 23 23
Partials 1 1
Continue to review full report at Codecov.
|
mkistler
force-pushed
the
mdk/fix-serviceUrl-check
branch
from
467c45e to
aef7bd1
Compare
|
On further consideration, I decided to drop the logic that grabs the serviceUrl from baseOptions if one is not specified. That was a half solution that isn't needed here and should be addressed fully in a separate PR (in the future). |
dpopp07
pushed a commit
that referenced
this pull request
Oct 3, 2019
dpopp07
pushed a commit
that referenced
this pull request
Oct 3, 2019
ibm-devx-automation
pushed a commit
that referenced
this pull request
Oct 3, 2019
# [1.0.0](v0.3.6...v1.0.0) (2019-10-03) ### Bug Fixes * Move check for serviceUrl to createRequest ([#47](#47)) ([6f04739](6f04739)) * parse result from response in token managers ([6bbe423](6bbe423)) * provide bundlers alternate file for browser support ([#58](#58)) ([88a9d16](88a9d16)) ### Build System * drop support for Node versions 6 and 8 ([#33](#33)) ([d47c737](d47c737)) ### Code Refactoring * look for credentials file in working dir before home dir ([#46](#46)) ([c5556de](c5556de)) * return detailed response as second callback argument ([#34](#34)) ([dc24154](dc24154)) ### Features * add `setServiceUrl` method as a setter for the `serviceUrl` property ([#41](#41)) ([cfb188f](cfb188f)) * add specific error handling for SSL errors with cloud private instances ([#54](#54)) ([056ec9a](056ec9a)) * export `UserOptions` interface from the BaseService ([#50](#50)) ([4f0075a](4f0075a)) * implement new authenticators to handle sdk authentication ([#37](#37)) ([f876b6d](f876b6d)) * refactor core to use Promises instead of callbacks ([#55](#55)) ([9ec8afd](9ec8afd)) ### BREAKING CHANGES * None of the authenticators or request methods take callbacks as arguments anymore - they return Promises instead. * Users that have credential files in both the working directory and the home directory will see a change in which one is used. * The internal property `url` no longer exists on the `baseOptions` object, it has been renamed to `serviceUrl` * The old style of passing credentials to the base service will no longer work. An Authenticator instance MUST be passed in to the base service constructor. * token managers no longer support user access tokens. use BearerTokenAuthenticator instead * The class names of the token managers have changed. * `Icp4dTokenManagerV1` renamed to `Cp4dTokenManager` * `IamTokenManagerV1` renamed to `IamTokenManager` * `JwtTokenManagerV1` renamed to `JwtTokenManager` * The public method `setAuthorizationInfo` is renamed to `setClientIdAndSecret` * The response body is no longer the 2nd callback argument, the detailed response is. The body is located under the `result` property. The `data` property is removed. * This SDK may no longer work with applications running on Node 6 or 8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the check for a non-empty serviceUrl to the createRequest method, so that sendRequest can be used from the authenticators which just pass
url.In addition, createRequest will take serviceUrl from the service baseOptions if none was provided in parameters.defaultOptions.
Tests were updated accordingly.