fix: use consistent fields between success and error response objects #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add fields `status` and `statusText` to error responses to match success responses
mkistler
approved these changes
Jan 30, 2020
|
That's a good idea. I'll open an issue for that on our board. |
ibm-devx-automation
pushed a commit
that referenced
this pull request
Jan 30, 2020
## [2.0.4](v2.0.3...v2.0.4) (2020-01-30) ### Bug Fixes * use consistent fields between success and error response objects ([#78](#78)) ([902d712](902d712))
|
🎉 This PR is included in version 2.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fields
statusandstatusTextare now added to the response error, to be consistent with the fields on a successful response object. The other fields are left intact for compatibility but are marked as deprecated so we know to remove them in the next major release.