feat: Pace requests to token server for new auth tokens #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkistler
force-pushed
the
mdk/pace-token-requests
branch
2 times, most recently
from
0204158 to
79f7da1
Compare
dpopp07
approved these changes
Mar 3, 2020
ricellis
approved these changes
Mar 5, 2020
There was a problem hiding this comment.
I think there are potentially ways this might behave unexpectedly in the case where token requests take around 1 minute, but I do think that risk is acceptable given that token requests should not be taking anywhere near that long.
Anyway I'm +1, although it might be worth resetting the requestTime when the token request completes.
mkistler
force-pushed
the
mdk/pace-token-requests
branch
from
dc71647 to
1f5fa56
Compare
mkistler
force-pushed
the
mdk/pace-token-requests
branch
from
1f5fa56 to
9c0aab8
Compare
ibm-devx-automation
pushed a commit
that referenced
this pull request
Mar 5, 2020
# [2.2.0](v2.1.0...v2.2.0) (2020-03-05) ### Features * Pace requests to token server for new auth tokens ([#83](#83)) ([b14dc4e](b14dc4e))
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
JurajNyiri
pushed a commit
to JurajNyiri/node-sdk-core
that referenced
this pull request
Aug 22, 2024
…BM#83) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.9.1 to 4.10.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.10.0/packages/parser) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a pacing method to regulate requests to the token service when the current token is invalid (never fetched) or expired. One caller is designated as the "active" request and it issues the request to the token server. Subsequent requests create promises that are added to a list, and the active request resolves (or rejects) these as part of processing the token server response.
Checklist
npm testpasses (tip:npm run lint-fixcan correct most style issues)