Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ibm-request-and-response-content): exempt minimally represented resource PUTs #659

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

dpopp07
Copy link
Member

@dpopp07 dpopp07 commented Apr 4, 2024

PR summary

According to the API Handbook, a PUT request on a minimally represented resource path is allowed to return a 201 with no content. This rule needed adjusting to make an exemption for this scenario.

PR Checklist

General checklist

Please make sure that your PR fulfills the following requirements:

…esource PUTs

According to the API Handbook, a PUT request on a minimally represented
resource path is allowed to return a 201 with no content. This rule needed
adjusting to make an exemption for this scenario.

Signed-off-by: Dustin Popp <dpopp07@gmail.com>
@dpopp07 dpopp07 requested a review from padamstx April 4, 2024 20:02
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpopp07 dpopp07 merged commit 40ee13c into main Apr 5, 2024
4 checks passed
@dpopp07 dpopp07 deleted the dp/minimally-represented-put branch April 5, 2024 16:43
ibm-devx-sdk pushed a commit that referenced this pull request Apr 5, 2024
## @ibm-cloud/openapi-ruleset [1.15.8](https://github.com/IBM/openapi-validator/compare/@ibm-cloud/openapi-ruleset@1.15.7...@ibm-cloud/openapi-ruleset@1.15.8) (2024-04-05)

### Bug Fixes

* **ibm-request-and-response-content:** exempt minimally represented resource PUTs ([#659](#659)) ([40ee13c](40ee13c))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 1.15.8 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@ibm-devx-sdk
Copy link

🎉 This PR is included in version 1.16.9 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@ibm-devx-sdk
Copy link

🎉 This PR is included in version 1.4.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants