Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skips validation for non-string enum values #67

Merged
merged 5 commits into from
Jun 19, 2019
Merged

fix: skips validation for non-string enum values #67

merged 5 commits into from
Jun 19, 2019

Conversation

SamerJaser96
Copy link
Contributor

Validator will skip validation of non-string enum values.

@SamerJaser96 SamerJaser96 changed the title fix: skips validation for non-string enuk values fix: skips validation for non-string enum values Jun 19, 2019
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, it's what we want. Just requesting a couple small changes

Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@dpopp07 dpopp07 merged commit fe4211f into master Jun 19, 2019
@dpopp07 dpopp07 deleted the enum branch June 19, 2019 18:01
dpopp07 pushed a commit that referenced this pull request Jun 19, 2019
## [0.11.1](v0.11.0...v0.11.1) (2019-06-19)

### Bug Fixes

* skips validation for non-string enum values ([#67](#67)) ([fe4211f](fe4211f))
@dpopp07
Copy link
Member

dpopp07 commented Jun 19, 2019

🎉 This PR is included in version 0.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants