fix(ibm-string-attributes): expand rule to apply to response schemas #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rule only applied to "input" schemas, which are more important to check for the attributes, but the API Handbook recommends the attributes for repsonse schemas as well. This commit expands the rule to check for those scenarios. Signed-off-by: Dustin Popp <dpopp07@gmail.com>
dpopp07
force-pushed
the
dp/response-string-attributes
branch
from
b0779c5
to
7d8f77f
Compare
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Sep 17, 2024
## @ibm-cloud/openapi-ruleset [1.21.2](https://github.com/IBM/openapi-validator/compare/@ibm-cloud/openapi-ruleset@1.21.1...@ibm-cloud/openapi-ruleset@1.21.2) (2024-09-17) ### Bug Fixes * **ibm-string-attributes:** expand rule to apply to response schemas ([#682](#682)) ([9e703ec](9e703ec))
|
🎉 This PR is included in version 1.21.2 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Sep 17, 2024
## ibm-openapi-validator [1.22.2](https://github.com/IBM/openapi-validator/compare/ibm-openapi-validator@1.22.1...ibm-openapi-validator@1.22.2) (2024-09-17) ### Bug Fixes * **ibm-string-attributes:** expand rule to apply to response schemas ([#682](#682)) ([9e703ec](9e703ec)) ### Dependencies * **@ibm-cloud/openapi-ruleset:** upgraded to 1.21.2
|
🎉 This PR is included in version 1.22.2 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rule only applied to "input" schemas, which are more important to check for the attributes, but the API Handbook recommends the attributes for repsonse schemas as well. This commit expands the rule to check for those scenarios.
PR summary
PR Checklist
General checklist
Please make sure that your PR fulfills the following requirements:
Checklist for adding a new validation rule: