fix: make schema path de-resolution utility more robust #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpopp07
commented
Sep 24, 2024
| for (const pathSegment of path.split('.')) { | ||
| const pathSegments = path.split('.'); | ||
|
|
||
| for (let i = 0; i < pathSegments.length; i++) { |
There was a problem hiding this comment.
The only real change is that now we use a numerically-indexed for-loop so that we know for sure when we're going through it for the last time.
padamstx
approved these changes
Sep 25, 2024
Before, the check used faulty logic to determine if we were on the last iteration through a loop. This could lead to unintended behavior in rare cases. This clarifies the logic to only execute the last time through the loop and for no other reason (the potential reason being if the last path segment matched an earlier path segment). Signed-off-by: Dustin Popp <dpopp07@gmail.com>
dpopp07
force-pushed
the
dp/fix-schemanameatpath
branch
from
b02761f
to
812c6ba
Compare
Good catch! Fixed |
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Sep 25, 2024
## @ibm-cloud/openapi-ruleset [1.23.1](https://github.com/IBM/openapi-validator/compare/@ibm-cloud/openapi-ruleset@1.23.0...@ibm-cloud/openapi-ruleset@1.23.1) (2024-09-25) ### Bug Fixes * make schema path de-resolution utility more robust ([#685](#685)) ([b25b840](b25b840))
|
🎉 This PR is included in version 1.23.1 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.24.1 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the check used faulty logic to determine if we were on the last iteration through a loop. This could lead to unintended behavior in rare cases. This clarifies the logic to only execute the last time through the loop and for no other reason (the potential reason being if the last path segment matched an earlier path segment).