fix(Catalog Management): add metadata and lastoperation to offering i… #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padamstx
approved these changes
Jun 8, 2021
| @@ -2119,6 +2120,9 @@ var _ = Describe(`CatalogManagementV1 Integration Tests (New)`, func() { | |||
|
|
|||
| offeringInstance, response, err := catalogManagementService.GetOfferingInstance(getOfferingInstanceOptions) | |||
|
|
|||
| fmt.Printf("%v\n", offeringInstance.Metadata) | |||
There was a problem hiding this comment.
Suggested change
| fmt.Printf("%v\n", offeringInstance.Metadata) | |
| fmt.Fprintf(GinkgoWriter, "%v\n", offeringInstance.Metadata) |
By using this form (similar to the print statement a few lines later), we see the output only if the -ginkgo.v command line option is used on the go test command.
|
I removed that print statement, since the metadata will be printed when the entire offering instance object is printed later on, it doesn't seem necessary to have it twice. @padamstx ready to merge |
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Jun 9, 2021
## [0.18.16](v0.18.15...v0.18.16) (2021-06-09) ### Bug Fixes * **Catalog Management:** add metadata and lastoperation to offering instance ([#126](#126)) ([097f824](097f824))
|
🎉 This PR is included in version 0.18.16 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nstance
PR summary
add metadata and lastoperation to offering instance
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
add metadata and lastoperation to offering instance object
Does this PR introduce a breaking change?
Other information