Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default service URLs has to be consistent accross all IAM SDKs #166

Closed
kavya498 opened this issue Nov 16, 2021 · 6 comments
Closed

Default service URLs has to be consistent accross all IAM SDKs #166

kavya498 opened this issue Nov 16, 2021 · 6 comments
Assignees

Comments

@kavya498
Copy link
Member

IAM Identity and IAMPAP uses default service url as iam.cloud.ibm.com
where as IAM Access group uses iam.cloud.ibm.com/v2

Terraform Provider uses one common environment variable IBMCLOUD_IAM_API_ENDPOINT for IAM related resources..
Since SDK is not consistent this would break provider when IBMCLOUD_IAM_API_ENDPOINT environment variable is exported..

Request to make default url as iam.cloud.ibm.com for IAM access group as well..

Thanks

@kavya498 kavya498 changed the title Defaukt service URLs has to be consistent accross all IAM SDKs Default service URLs has to be consistent accross all IAM SDKs Nov 16, 2021
@padamstx
Copy link
Member

padamstx commented Nov 16, 2021

Hi @kavya498, this change would need to be done by the service team that owns the IAM Access Groups API. First the API definition would need to change (the "/v2" part would need to be moved from the server url definition to each of the path entries within the API definition), then the SDK code for each of the SDKs will need to be re-generated and delivered in a new release of each SDK.

@padamstx
Copy link
Member

@mamillapalle Nagarjuna, could you please take this one?

@narinder-kaur
Copy link
Member

@padamstx I will take care of this.

@padamstx
Copy link
Member

@narinder-kaur Just added you to the "writers" group for the platform services SDK projects. This should allow you to push a new branch and open a PR without having to use a fork.

@narinder-kaur
Copy link
Member

@padamstx #169 has been merged. So this issue can be closed, or should be kept open for further verification?

@padamstx
Copy link
Member

padamstx commented Dec 6, 2021

The platform-services SDKs have all been updated to reflect the updated API definition where the "/v2" part of the service URL was moved to each individual path value. This will now allow a user to use a service URL like https://iam.cloud.ibm.com, like the other IAM-related services.

@padamstx padamstx closed this as completed Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants