Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Activity Tracker): adds remapping to other regions #207

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

MajinBui
Copy link
Contributor

PR summary

Atracker Changes version 1 and 2: Adds in service regions remapped for the following:

provider region ATracker region
ca-tor us-east
br-sao us-south
eu-fr2 eu-de
jp-tok eu-de
jp-osa eu-de
in-che eu-de

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@padamstx padamstx self-requested a review September 29, 2022 21:09
@padamstx padamstx self-assigned this Sep 29, 2022
@padamstx
Copy link
Member

As I mentioned on slack, please re-gen both services with the latest version of the SDK generator (v3.57.1). Thanks!

Signed-off-by: Van Chau Bui <van.bui@ibm.com>
@MajinBui MajinBui force-pushed the update-regions-atracker branch from 78b16fb to f9b87ae Compare September 29, 2022 21:40
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
As soon as I get confirmation that the integration tests and examples run clean for both services, I can merge. Thanks!

@padamstx padamstx merged commit 6674728 into IBM:main Sep 29, 2022
ibm-devx-sdk pushed a commit that referenced this pull request Sep 29, 2022
## [0.28.5](v0.28.4...v0.28.5) (2022-09-29)

### Bug Fixes

* **Activity Tracker:** add remapping to other regions ([#207](#207)) ([6674728](6674728))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.28.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants