Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Resource Controller): re-gen service to get new Pagers #216

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented Nov 1, 2022

PR summary

This commit contains a re-gen of the Resource Controller service to leverage the new Pagers emitted by
the SDK generator.

Signed-off-by: Phil Adams phil_adams@us.ibm.com

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@phanziii phanziii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This commit contains a re-gen of the Resource Controller
service to leverage the new Pagers emitted by
the SDK generator.

Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
@padamstx padamstx merged commit 352c902 into main Nov 3, 2022
@padamstx padamstx deleted the regen-rc branch November 3, 2022 13:55
ibm-devx-sdk pushed a commit that referenced this pull request Nov 3, 2022
## [0.29.3](v0.29.2...v0.29.3) (2022-11-03)

### Bug Fixes

* **Resource Controller:** re-gen service to get new Pagers ([#216](#216)) ([352c902](352c902))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.29.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants