fix(Global Search/Tagging): regenerated services with latest API definition #228
Conversation
…nition. Signed-off-by: Fabrizio Leoni <fabrizio_leoni@it.ibm.com>
|
|
globalsearchv2/global_search_v2.go
Outdated
|
|
||
| // Value of the limit parameter specified by the user. | ||
| Limit *int64 `json:"limit,omitempty"` | ||
| Limit *float64 `json:"limit" validate:"required"` |
There was a problem hiding this comment.
The "limit" property of the ScanResult schema should most likely be defined as "integer" instead of "number". Apparently, back when this service was last re-generated (by @damianovesperini on 6/10/2021) the property was in fact defined as "integer" which is why the current version of the code is using "int64". It looks like search.yaml was updated in this commit to use "number" instead of "integer". I think this should be changed back to "integer" in the API definition.
There was a problem hiding this comment.
It will be fixed
There was a problem hiding this comment.
@fabrizio-leoni When the API definition is fixed for this problem and the endpoint URL issue, you'll need to regen the SDK code one more time, then update the PR with the changes. Also, be sure to pull in the latest changes from the main branch as well.
|
|
|
|
## [0.31.3](v0.31.2...v0.31.3) (2023-01-17) ### Bug Fixes * **Global Search & Tagging:** regen services with latest API definition ([#228](#228)) ([a76ab70](a76ab70))
|
🎉 This PR is included in version 0.31.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Signed-off-by: Fabrizio Leoni fabrizio_leoni@it.ibm.com
PR summary
SDK regenerated API definition starting from https://test.cloud.ibm.com/apidocs/tagging https://test.cloud.ibm.com/apidocs/search
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Does this PR introduce a breaking change?
Other information