Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IAM Identity): Add support for IAM enterprise #267

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

michaelbeck
Copy link
Contributor

@michaelbeck michaelbeck commented Jul 24, 2023

PR summary

Added support for IAM enterprise feature. Enterprise admins can create templates for account settings and trusted profiles and assign them to accounts and account groups in the enterprise.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

SDK adopters will be able to work with IAM enterprise feature.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

API definition: Staging

Test information:

Integration Tests:

Ran 490 of 490 Specs in 814.586 seconds
SUCCESS! -- 490 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok      github.com/IBM/platform-services-go-sdk/iamidentityv1   817.700s

Examples:

Ran 473 of 473 Specs in 759.903 seconds
SUCCESS! -- 473 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok      github.com/IBM/platform-services-go-sdk/iamidentityv1   763.477s

@padamstx
Copy link
Member

@michaelbeck Looks like your PR build had some linter errors. Based on the messages, I'm guessing that you defined the same function in both the integration tests and examples code. Unfortunately, when we run the linter we use --build-tags=integration,examples which means all the code inside the service package directory will be "seen" by the linter and since all the code is part of the same package, the linter detects that the functions are actually defined twice in the two different source files. I guess the easiest solution is to rename the functions in one of the files so they're unique.

@padamstx
Copy link
Member

BTW, each SDK has some detailed developer instructions in the update_service.md file (linked from CONTRIBUTING.md), but specifically... you can run make all in your local sandbox and it will run the unit test and linter steps, similar to an automated Travis run. That way you can head off errors like this before pushing your changes to remote, etc.

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the issues I mentioned above, the changes look good.
Just need to address the linter errors.

@michaelbeck
Copy link
Contributor Author

@michaelbeck Looks like your PR build had some linter errors. Based on the messages, I'm guessing that you defined the same function in both the integration tests and examples code. Unfortunately, when we run the linter we use --build-tags=integration,examples which means all the code inside the service package directory will be "seen" by the linter and since all the code is part of the same package, the linter detects that the functions are actually defined twice in the two different source files. I guess the easiest solution is to rename the functions in one of the files so they're unique.

Sorry, I just ran them separately, thus I wouldn't notice. Should be corrected now.

@michaelbeck
Copy link
Contributor Author

BTW, each SDK has some detailed developer instructions in the update_service.md file (linked from CONTRIBUTING.md), but specifically... you can run make all in your local sandbox and it will run the unit test and linter steps, similar to an automated Travis run. That way you can head off errors like this before pushing your changes to remote, etc.

I tried to respect what was written in the readmes there. But neither go test nor go test ./...seemed to run any meaningful test, so I ignored them. Sorry :-(

Signed-off-by: Michael Beck <beckm@de.ibm.com>
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@padamstx padamstx merged commit d23f0fc into IBM:main Jul 24, 2023
ibm-devx-sdk pushed a commit that referenced this pull request Jul 24, 2023
# [0.42.0](v0.41.0...v0.42.0) (2023-07-24)

### Features

* **IAM Identity:** Add support for IAM enterprise ([#267](#267)) ([d23f0fc](d23f0fc))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.42.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants