Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(atracker): Removed deprecated atrackerv1 version code #282

Merged
merged 1 commit into from
Oct 3, 2023
Merged

fix(atracker): Removed deprecated atrackerv1 version code #282

merged 1 commit into from
Oct 3, 2023

Conversation

adya1303
Copy link
Contributor

@adya1303 adya1303 commented Oct 3, 2023 •
edited by johnymathew
Loading

PR summary

Atrackerv1 is deprecated and as part of this PR, removing all the code related to it.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Not modifying the current behaviour. Just the deprecated version is getting removed.

Does this PR introduce a breaking change?

  • Yes
  • No

Since the atrackerv1 is deprecated, anyone who is using the v1 version have to start using atrackerv2.

fix(atracker): Removed deprecated atrackerv1 version code
fe3a0a2 
Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com>
@adya1303 adya1303 marked this pull request as draft October 3, 2023 05:52
@adya1303
Copy link
Contributor Author

adya1303 commented Oct 3, 2023

Ran tests -

go test github.com/IBM/platform-services-go-sdk/atrackerv2 -tags="integration" -v
=== RUN   TestAtrackerV2
Running Suite: AtrackerV2 Suite
===============================
Random Seed: 1696317600
Will run 136 of 136 specs

•••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 136 of 136 Specs in 32.621 seconds
SUCCESS! -- 136 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestAtrackerV2 (32.70s)
PASS
ok  	github.com/IBM/platform-services-go-sdk/atrackerv2	34.460s

 go test
Running Suite: AtrackerV2 Suite
===============================
Random Seed: 1696317665
Will run 93 of 93 specs

•••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 93 of 93 Specs in 3.485 seconds
SUCCESS! -- 93 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok  	github.com/IBM/platform-services-go-sdk/atrackerv2	3.996s

@adya1303 adya1303 marked this pull request as ready for review October 3, 2023 13:59
@adya1303 adya1303 requested a review from padamstx October 3, 2023 13:59
@padamstx padamstx self-assigned this Oct 3, 2023
padamstx
padamstx approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 1b7cff8 into IBM:main Oct 3, 2023
2 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Oct 3, 2023
@semantic-release-bot
chore(release): 0.51.0 release notes [skip ci]
c6dff2b 
# [0.51.0](v0.50.4...v0.51.0) (2023-10-03)

### Features

* **ATracker V1:** remove deprecated atrackerv1 service from project ([#282](#282)) ([1b7cff8](1b7cff8))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.51.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adya1303 @ibm-devx-sdk @padamstx