Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(IAM Policy Management): update rule conditions based on API def #288

Merged
merged 4 commits into from
Nov 7, 2023
Merged

fix(IAM Policy Management): update rule conditions based on API def #288

merged 4 commits into from
Nov 7, 2023

Conversation

swcolley
Copy link
Contributor

@swcolley swcolley commented Nov 7, 2023

PR summary

Updated based on minor api definition update.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Tests:

go test -v -tags=examples
...
Ran 214 of 214 Specs in 13.682 seconds
SUCCESS! -- 214 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestIamPolicyManagementV1 (13.74s)
PASS
ok  	github.com/IBM/platform-services-go-sdk/iampolicymanagementv1	14.191s

go test -v -tags=integration
...
Ran 212 of 212 Specs in 22.645 seconds
SUCCESS! -- 212 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestIamPolicyManagementV1 (22.70s)
PASS
ok  	github.com/IBM/platform-services-go-sdk/iampolicymanagementv1	22.931s

@padamstx padamstx self-requested a review November 7, 2023 14:18
@padamstx padamstx self-assigned this Nov 7, 2023
@padamstx padamstx changed the title fix(IAM Policy Management): Updated rule conditions based on API def fix(IAM Policy Management): update rule conditions based on API def Nov 7, 2023
padamstx
padamstx approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit aa2f6a2 into main Nov 7, 2023
3 checks passed
@padamstx padamstx deleted the policyNestedConditions branch November 7, 2023 18:19
ibm-devx-sdk pushed a commit that referenced this pull request Nov 7, 2023
@semantic-release-bot
chore(release): 0.53.1 release notes [skip ci]
95b9f04 
## [0.53.1](v0.53.0...v0.53.1) (2023-11-07)

### Bug Fixes

* **IAM Policy Management:** update rule conditions based on API def ([#288](#288)) ([aa2f6a2](aa2f6a2))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.53.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swcolley @ibm-devx-sdk @padamstx