Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IAM Policy Management): update examples format for doc generation #299

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

swcolley
Copy link
Contributor

PR summary

Issue: https://github.ibm.com/IAM/AM-issues/issues/2001

Updating examples so that the API doc generation includes the etag response header.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

No behavior change.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Ran examples to verify changes:

go test -tags=examples
Running Suite: IamPolicyManagementV1 Suite
==========================================
Random Seed: 1706561751
Will run 214 of 214 specs
...
Ran 214 of 214 Specs in 13.503 seconds
SUCCESS! -- 214 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
@padamstx padamstx self-requested a review January 30, 2024 21:21
@padamstx padamstx self-assigned this Jan 30, 2024
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 8074d5b into main Jan 30, 2024
4 checks passed
@padamstx padamstx deleted the etagExampleFix branch January 30, 2024 22:21
ibm-devx-sdk pushed a commit that referenced this pull request Jan 30, 2024
## [0.56.4](v0.56.3...v0.56.4) (2024-01-30)

### Bug Fixes

* **IAM Policy Management:** update examples format for doc generation ([#299](#299)) ([8074d5b](8074d5b))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.56.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants