Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IAM Identity): add disable_api_key and enable_api_key operations #309

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

pooraniss-ibm
Copy link
Member

@pooraniss-ibm pooraniss-ibm commented Mar 14, 2024

PR summary

two new endpoints for apikey: Disable apikey and Enable apikey

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Screenshot 2024-03-13 at 16 35 53

@padamstx padamstx self-assigned this Mar 14, 2024
@padamstx padamstx self-requested a review March 14, 2024 18:19
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to re-gen with recent SDK generator version.

@@ -15,7 +15,7 @@
*/

/*
* IBM OpenAPI SDK Code Generator Version: 3.80.0-29334a73-20230925-151553
* IBM OpenAPI SDK Code Generator Version: 3.62.0-a2a22f95-20221115-162524
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version of the SDK generator you used is a year and a half old. Please install the most recent version and re-generate your code.

@pooraniss-ibm pooraniss-ibm force-pushed the iam-identity-disableapikey branch from 0afea05 to d0d7ffe Compare March 25, 2024 14:29
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx changed the title feat(IAM Identity): adding disable apikey feat(IAM Identity): add disable_api_key and enable_api_key operations Mar 25, 2024
@padamstx padamstx force-pushed the iam-identity-disableapikey branch from d0d7ffe to 536c29d Compare March 25, 2024 17:44
Signed-off-by: poorani <poorani.senthilkumar.sankari@ibm.com>
@padamstx padamstx force-pushed the iam-identity-disableapikey branch from 536c29d to f3541b1 Compare March 25, 2024 17:50
@padamstx padamstx merged commit 2480803 into main Mar 25, 2024
4 checks passed
@padamstx padamstx deleted the iam-identity-disableapikey branch March 25, 2024 17:56
ibm-devx-sdk pushed a commit that referenced this pull request Mar 25, 2024
# [0.62.0](v0.61.4...v0.62.0) (2024-03-25)

### Features

* **IAM Identity:** add disable_api_key and enable_api_key operations ([#309](#309)) ([2480803](2480803))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.62.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants