fix(IAM Policy Management): S2S support for enterprise accounts #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rajesh K Pirati <rajesh.pirati@ibm.com>
swcolley
requested changes
Apr 8, 2024
|
|
||
| It(`CreatePolicyS2STemplate request example`, func() { | ||
| fmt.Println("\nCreatePolicyS2STemplate() result:") | ||
| // begin-create_policy_template |
There was a problem hiding this comment.
This has the same name as line 708. Can be an issue with example generation in the docs if this are named same? I think there might be a collison.
There was a problem hiding this comment.
yes, only one code block per operation
| examplePolicyS2STemplateVersion = *policyTemplate.Version | ||
| fmt.Println(string(b)) | ||
|
|
||
| // end-create_policy_template |
…ents Signed-off-by: Rajesh K Pirati <rajesh.pirati@ibm.com>
padamstx
requested changes
Apr 8, 2024
|
|
||
| It(`CreatePolicyS2STemplate request example`, func() { | ||
| fmt.Println("\nCreatePolicyS2STemplate() result:") | ||
| // begin-create_authorization_policy_template |
There was a problem hiding this comment.
Suggested change
| // begin-create_authorization_policy_template | |
| // begin-create_policy_template |
One example code block per operation, and the operation id in the "begin" and "end" comments must match the operationId in the API definition
| @@ -820,6 +901,72 @@ var _ = Describe(`IamPolicyManagementV1 Examples Tests`, func() { | |||
| Expect(policyTemplate).ToNot(BeNil()) | |||
| }) | |||
|
|
|||
| It(`CreatePolicyS2STemplateVersion request example`, func() { | |||
| fmt.Println("\nCreatePolicyS2STemplateVersion() result:") | |||
| // begin-create_authorization_policy_template_version | |||
There was a problem hiding this comment.
Same issue as the create_policy_template examples
|
ran again example tests after fixing the review comments |
…ents on examples Signed-off-by: Rajesh K Pirati <rajesh.pirati@ibm.com>
|
|
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Apr 10, 2024
## [0.62.4](v0.62.3...v0.62.4) (2024-04-10) ### Bug Fixes * **IAM Policy Management:** S2S support for enterprise accounts ([#317](#317)) ([4d65f3d](4d65f3d))
|
🎉 This PR is included in version 0.62.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Authorization policy type support for enterprise accounts
issue: https://github.ibm.com/IAM/AM-issues/issues/2350
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Does this PR introduce a breaking change?
Other information
test results
example:
integration
