Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Usage Reports): re-gen service to pickup changes to Instance Reports #331

Merged
merged 3 commits into from
Jun 18, 2024
Merged

feat(Usage Reports): re-gen service to pickup changes to Instance Reports #331

merged 3 commits into from
Jun 18, 2024

Conversation

Jdatechong
Copy link
Contributor

PR summary

Adds the VolumeDiscount and VolumeCost field to the metric type

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Adds the VolumeDiscount and VolumeCost field to the metric type

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Tests:

•••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 109 of 109 Specs in 3.485 seconds
SUCCESS! -- 109 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok      github.com/IBM/platform-services-go-sdk/usagereportsv4  4.369s

Integration tests:

••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 132 of 132 Specs in 23.595 seconds
SUCCESS! -- 132 Passed | 0 Failed | 0 Pending | 0 Skipped

Examples:

Ran 124 of 124 Specs in 19.949 seconds
SUCCESS! -- 124 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok      github.com/IBM/platform-services-go-sdk/usagereportsv4  20.567s

Jdatechong added 3 commits June 7, 2024 13:40
@Jdatechong
add VolumeDiscount and VolumeCost
27e8dd5 
Signed-off-by: Jonathan Date-chong <jtdatechong@gmail.com>
@Jdatechong
regenerate tests to include VolumeDiscount and VolumeCost
61fd2f9 
Signed-off-by: Jonathan Date-chong <jtdatechong@gmail.com>
@Jdatechong
modify tests to reduce formatting changes on regeneration
621b585 
Signed-off-by: Jonathan Date-chong <jtdatechong@gmail.com>
@padamstx padamstx self-requested a review June 18, 2024 16:06
@padamstx padamstx self-assigned this Jun 18, 2024
padamstx
padamstx approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 3d034e7 into IBM:main Jun 18, 2024
3 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Jun 18, 2024
@semantic-release-bot
chore(release): 0.64.0 release notes [skip ci]
5349179 
# [0.64.0](v0.63.1...v0.64.0) (2024-06-18)

### Features

* **Usage Reports:** re-gen service to pickup changes to Instance Reports  ([#331](#331)) ([3d034e7](3d034e7))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.64.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jdatechong @ibm-devx-sdk @padamstx