Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(IAM Policy Management): re-gen service and add examples after recent API changes #77

Merged
merged 14 commits into from
Feb 25, 2021
Merged

fix(IAM Policy Management): re-gen service and add examples after recent API changes #77

merged 14 commits into from
Feb 25, 2021

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented Jan 29, 2021 •
edited
Loading

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@padamstx padamstx self-assigned this Jan 29, 2021
@padamstx
Copy link
Member Author

@guicabr, this is the Go PR. Examples are located in the iampolicymanagementv1 package directory.

@padamstx padamstx changed the base branch from master to main February 9, 2021 21:29
@padamstx padamstx assigned guicabr and padamstx and unassigned padamstx and guicabr Feb 16, 2021
padamstx
padamstx commented Feb 16, 2021
View reviewed changes
Copy link
Member Author

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just 1 minor comment about variable names

iampolicymanagementv1/iam_policy_management_v1_examples_test.go Outdated

testUserId = "IBMid-GoSDK" + strconv.Itoa(rand.Intn(100000))
testServiceName = "iam-groups"
testAccountId string
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider changing variable names that show up in example code snippets to use example instead of test.

guicabr
guicabr reviewed Feb 25, 2021
View reviewed changes
Copy link
Contributor

@guicabr guicabr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guicabr guicabr merged commit 6ae8d2d into main Feb 25, 2021
ibm-devx-automation pushed a commit that referenced this pull request Feb 25, 2021
@semantic-release-bot
chore(release): 0.17.15 release notes [skip ci]
69bdd60 
## [0.17.15](v0.17.14...v0.17.15) (2021-02-25)

### Bug Fixes

* **IAM Policy Management:** re-gen service and add examples after recent API changes ([#77](#77)) ([6ae8d2d](6ae8d2d))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.17.15 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@christiancompton christiancompton deleted the update-ipm branch February 25, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guicabr guicabr guicabr approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@padamstx @ibm-devx-automation @guicabr