Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Global Catalog): regen service and add working examples #81

Merged
merged 6 commits into from
Feb 18, 2021

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented Feb 11, 2021

PR summary

This PR contains a regen of the Global Catalog service and adds working examples

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@padamstx padamstx changed the title fix(Global Catalog): regen service and add working examples WIP: fix(Global Catalog): regen service and add working examples Feb 11, 2021
@padamstx padamstx force-pushed the gc-examples branch 3 times, most recently from 5dfd4b7 to 541ee27 Compare February 12, 2021 00:44
@padamstx padamstx changed the title WIP: fix(Global Catalog): regen service and add working examples fix(Global Catalog): regen service and add working examples Feb 12, 2021
@padamstx padamstx requested a review from pyrooka February 12, 2021 00:45
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 9ec0801 into main Feb 18, 2021
@padamstx padamstx deleted the gc-examples branch February 18, 2021 22:31
ibm-devx-automation pushed a commit that referenced this pull request Feb 18, 2021
## [0.17.10](v0.17.9...v0.17.10) (2021-02-18)

### Bug Fixes

* **Global Catalog:** regen service and add working examples ([#81](#81)) ([9ec0801](9ec0801))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.17.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants