Skip to content

Commit f33b6af

Browse files
committed
test: use built-in getQueryParam function instead of a custom one
1 parent 6fe89b3 commit f33b6af

File tree

1 file changed

+4
-15
lines changed

1 file changed

+4
-15
lines changed

test/integration/enterprise-management.v1.test.js

+4-15
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
'use strict';
1919
const EnterpriseManagementV1 = require('../../dist/enterprise-management/v1');
20-
const { readExternalSources } = require('ibm-cloud-sdk-core');
20+
const { readExternalSources, getQueryParam } = require('ibm-cloud-sdk-core');
2121
const authHelper = require('../resources/auth-helper.js');
2222

2323
// testcase timeout value (200s).
@@ -97,7 +97,7 @@ describe('EnterpriseManagementV1_integration', () => {
9797
results = results.concat(res.result.resources);
9898

9999
if (res.result.next_url) {
100-
nextDocid = getNextDocid(res.result.next_url);
100+
nextDocid = getQueryParam(res.result.next_url, 'next_docid');
101101
} else {
102102
nextDocid = null;
103103
}
@@ -162,7 +162,7 @@ describe('EnterpriseManagementV1_integration', () => {
162162
results = results.concat(res.result.resources);
163163

164164
if (res.result.next_url) {
165-
nextDocid = getNextDocid(res.result.next_url);
165+
nextDocid = getQueryParam(res.result.next_url, 'next_docid');
166166
} else {
167167
nextDocid = null;
168168
}
@@ -211,7 +211,7 @@ describe('EnterpriseManagementV1_integration', () => {
211211
results = results.concat(res.result.resources);
212212

213213
if (res.result.next_url) {
214-
nextDocid = getNextDocid(res.result.next_url);
214+
nextDocid = getQueryParam(res.result.next_url, 'next_docid');
215215
} else {
216216
nextDocid = null;
217217
}
@@ -242,14 +242,3 @@ describe('EnterpriseManagementV1_integration', () => {
242242
expect(res.result).toBeDefined();
243243
});
244244
});
245-
246-
function getNextDocid(urlstring) {
247-
let offset = null;
248-
if (urlstring) {
249-
// We use a bogus "baseurl" in case "urlstring" is a relative url.
250-
// This is fine since we're only trying to retrieve the "offset" query parameter.
251-
const url = new URL(urlstring, 'https://fakehost.com');
252-
offset = url.searchParams.get('next_docid');
253-
}
254-
return offset;
255-
}

0 commit comments

Comments
 (0)