Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: public publish to org #119

Merged
merged 1 commit into from
Jul 21, 2021
Merged

fix: public publish to org #119

merged 1 commit into from
Jul 21, 2021

Conversation

Andras-Csanyi
Copy link
Contributor

@Andras-Csanyi Andras-Csanyi commented Jul 21, 2021 •
edited
Loading

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@codecov
Copy link

codecov bot commented Jul 21, 2021 •
edited
Loading

Codecov Report

Merging #119 (e407ecf) into main (751dc4d) will not change coverage.
The diff coverage is n/a.

❗ Current head e407ecf differs from pull request most recent head 9f6ecd4. Consider uploading reports for the commit 9f6ecd4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main      #119   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         3302      3302           
  Branches       402       402           
=========================================
  Hits          3302      3302

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa9968f...9f6ecd4. Read the comment docs.

padamstx
padamstx approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dpopp07
dpopp07 approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@Andras-Csanyi Andras-Csanyi merged commit 68e38e3 into main Jul 21, 2021
ibm-devx-sdk pushed a commit that referenced this pull request Jul 21, 2021
@semantic-release-bot
chore(release): 0.19.2 [skip ci]
0a6f416 
## [0.19.2](v0.19.1...v0.19.2) (2021-07-21)

### Bug Fixes

* add public publish option ([#119](#119)) ([68e38e3](68e38e3))
@Andras-Csanyi Andras-Csanyi deleted the set_publish_scope_to_public branch July 21, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpopp07 dpopp07 dpopp07 approved these changes

@padamstx padamstx padamstx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Andras-Csanyi @dpopp07 @padamstx