Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Posture Management): Add posture management service sdk #86

Merged
merged 20 commits into from
Mar 26, 2021
Merged

feat(Posture Management): Add posture management service sdk #86

merged 20 commits into from
Mar 26, 2021

Conversation

Andras-Csanyi
Copy link
Contributor

@Andras-Csanyi Andras-Csanyi commented Mar 9, 2021 •
edited
Loading

PR summary

This PR contains the following for Posture Management

  • generated service SDK
  • generated unit tests
  • generated integration tests
  • generated examples

Further todo before merge:

  • align integration tests
  • introduce configuration values via .env file
  • double URL in the README.md file

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@codecov
Copy link

codecov bot commented Mar 9, 2021 •
edited
Loading

Codecov Report

Merging #86 (ab0389b) into main (794cb13) will not change coverage.
The diff coverage is 100.00%.

❗ Current head ab0389b differs from pull request most recent head 1673957. Consider uploading reports for the commit 1673957 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              main       #86    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           19        20     +1     
  Lines         2898      3021   +123     
  Branches       369       388    +19     
==========================================
+ Hits          2898      3021   +123
Impacted Files Coverage Δ
global-search/v2.ts 100.00% <ø> (ø)
resource-manager/v2.ts 100.00% <ø> (ø)
iam-identity/v1.ts 100.00% <100.00%> (ø)
posture-management/v1.ts 100.00% <100.00%> (ø)
resource-controller/v2.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0af443f...1673957. Read the comment docs.

@Andras-Csanyi Andras-Csanyi self-assigned this Mar 9, 2021
@Andras-Csanyi Andras-Csanyi marked this pull request as draft March 10, 2021 13:01
@Andras-Csanyi Andras-Csanyi marked this pull request as ready for review March 13, 2021 15:56
Andras-Csanyi and others added 16 commits March 14, 2021 12:56
@Andras-Csanyi
Merge branch 'main' into add-posture-management-service-sdk
afa5dfe
@Andras-Csanyi
feat(posture management): add configuration values to integration tests.
a5da58c
@Andras-Csanyi
feat(posture management): align examples
41e988d
@Andras-Csanyi
feat(posture management): fix README.md link to Posture Management do…
2a35cc5 
…c page.
@Andras-Csanyi
Merge branch 'main' into add-posture-management-service-sdk
1dfff9e
@Andras-Csanyi
fix: update .secrets-baseline
0eadf6a
@Andras-Csanyi
Merge branch 'main' into add-posture-management-service-sdk
7a555f9
@padamstx
Merge branch 'main' into add-posture-management-service-sdk
47e1301
@Andras-Csanyi
fix(posture management): update service and unit test
d5ed3e7
@Andras-Csanyi
fix(posture management): update integration test
3122f1e
@Andras-Csanyi
fix(posture management): update example
3a43d33
@Andras-Csanyi
fix(posture management): update integration test
7b627d8
@Andras-Csanyi
fix(posture management): update examples
48dd2cd
@Andras-Csanyi
Merge branch 'add-posture-management-service-sdk' of github.com:IBM/p…
0fe02ba 
…latform-services-node-sdk into add-posture-management-service-sdk
@Andras-Csanyi
fix(posture management) update .secrets.baseline
c5359cf
@Andras-Csanyi
fix(posture management): add labels to examples
19b81ac
@Andras-Csanyi Andras-Csanyi changed the title feat(Posture Management): Add posture management service sdk - DRAFT feat(Posture Management): Add posture management service sdk Mar 25, 2021
padamstx
padamstx approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx assigned padamstx and unassigned Andras-Csanyi Mar 25, 2021
@padamstx padamstx merged commit 9932725 into main Mar 26, 2021
@padamstx padamstx deleted the add-posture-management-service-sdk branch March 26, 2021 16:01
ibm-devx-automation pushed a commit that referenced this pull request Mar 26, 2021
@semantic-release-bot
chore(release): 0.18.0 [skip ci]
b4db770 
# [0.18.0](v0.17.18...v0.18.0) (2021-03-26)

### Features

* **Posture Management:** Add service to project ([#86](#86)) ([9932725](9932725))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

@pyrooka pyrooka Awaiting requested review from pyrooka

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Andras-Csanyi @ibm-devx-automation @padamstx