fix(Enterprise Management): update service after recent API changes and add examples #102

pyrooka · 2021-04-08T13:11:14Z

PR summary

This PR updates the Enterprise Management service after recent API changes. Also adds working examples.

PR Checklist

Please make sure that your PR fulfills the following requirements:

The commit message follows the Angular Commit Message Guidelines.
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

Yes
No

Other information

codecov · 2021-04-08T13:11:31Z

Codecov Report

Merging #102 (40e6c76) into main (a1c5fa3) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage   93.65%   93.65%           
=======================================
  Files          22       22           
  Lines       20641    20641           
=======================================
  Hits        19332    19332           
  Misses       1309     1309

Impacted Files	Coverage Δ
ibm_platform_services/enterprise_management_v1.py	`95.78% <ø> (ø)`
ibm_platform_services/version.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 938a74e...40e6c76. Read the comment docs.

padamstx · 2021-04-09T22:04:47Z

examples/test_enterprise_management_v1_examples.py

+
+            create_account_group_response = enterprise_management_service.create_account_group(
+                parent=parent,
+                name=first_account_group_name,


Suggested change

name=first_account_group_name,

name='Example Account Group',

padamstx · 2021-04-09T22:05:26Z

examples/test_enterprise_management_v1_examples.py

+            global first_account_group_id
+            first_account_group_id = create_account_group_response.get('account_group_id')
+
+            create_second_account_group_response = enterprise_management_service.create_account_group(


formatting issues?

padamstx · 2021-04-09T22:06:21Z

examples/test_enterprise_management_v1_examples.py

+enterprise_account_iam_id = None
+
+account_id = None
+first_account_group_id = None


Suggested change

first_account_group_id = None

account_group_id = None

padamstx · 2021-04-09T22:06:39Z

examples/test_enterprise_management_v1_examples.py

+
+account_id = None
+first_account_group_id = None
+second_account_group_id = None


Suggested change

second_account_group_id = None

new_parent_account_group_id = None

padamstx · 2021-04-09T22:06:58Z

examples/test_enterprise_management_v1_examples.py

+            # end-create_account_group
+
+            global first_account_group_id
+            first_account_group_id = create_account_group_response.get('account_group_id')


Suggested change

first_account_group_id = create_account_group_response.get('account_group_id')

account_group_id = create_account_group_response.get('account_group_id')

padamstx · 2021-04-09T22:15:39Z

examples/test_enterprise_management_v1_examples.py

+
+            response = enterprise_management_service.update_enterprise(
+                enterprise_id=enterprise_id,
+                name=updated_enterprise_name,


Suggested change

name=updated_enterprise_name,

name='Updated Example Enterprise',

padamstx · 2021-04-09T22:18:54Z

test/integration/test_enterprise_management_v1.py

+            list_account_groups_response = list_account_groups_response.get_result()
+            assert list_account_groups_response is not None
+
+            results_count += 1


Suggested change

results_count += 1

results_count += list_account_groups_response.get('rows_count')

Yes, on the surface, this is equivalent to just incrementing the count by 1, but if we ever change limit, then you're innoculated :)

padamstx · 2021-04-09T22:20:07Z

test/integration/test_enterprise_management_v1.py

+        example_account_id = create_account_response.get('account_id')
+
+    @needscredentials
+    def test_list_accounts(self):


for list operations, I think testing the operation with pagination is sufficient since the "without pagination" scenario is a subset of the "with pagination" scenario.

padamstx · 2021-04-09T22:20:53Z

test/integration/test_enterprise_management_v1.py

+        assert update_account_response.get_status_code() == 202
+
+    @needscredentials
+    def test_list_enterprises(self):


Need to add pagination to this test

padamstx · 2021-04-09T22:22:23Z

test/integration/test_enterprise_management_v1.py

+        second_example_account_group_id = create_second_example_account_group_response.get('account_group_id')
+
+    @needscredentials
+    def test_list_account_groups(self):


we can remove this "without pagination" test

CLAassistant · 2021-04-12T13:53:48Z

All committers have signed the CLA.

padamstx · 2021-04-12T14:30:38Z

examples/test_enterprise_management_v1_examples.py

+
+            response = enterprise_management_service.update_enterprise(
+                enterprise_id=enterprise_id,
+                name='Updated Enterprise Name',


Suggested change

name='Updated Enterprise Name',

name='Updated Example Enterprise',

Check are the created resource IDs in the results of the list operations.

## [0.18.5](v0.18.4...v0.18.5) (2021-04-13) ### Bug Fixes * **Enterprise Management:** update service after recent API changes and add examples ([#102](#102)) ([6eaa326](6eaa326))

ibm-devx-sdk · 2021-04-13T19:10:33Z

🎉 This PR is included in version 0.18.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

pyrooka added 3 commits April 8, 2021 11:40

fix(Enterprise Management): re-gen service after recent API changes

39a7265

chore: update integration tests

2761990

chore: add pagination integration tests

592fa39

chore: add working examples

45396b1

pyrooka changed the title ~~fix(Enterprise Management): update service after recent API changes~~ fix(Enterprise Management): update service after recent API changes and add examples Apr 9, 2021

pyrooka requested a review from padamstx April 9, 2021 13:35

pyrooka added 2 commits April 9, 2021 16:17

chore: minor fix and add print labels to the examples

a312257

chore: minor fix

21862a1

padamstx requested changes Apr 9, 2021

View reviewed changes

chore: requested changes

c510698

padamstx reviewed Apr 12, 2021

View reviewed changes

pyrooka and others added 4 commits April 12, 2021 16:41

chore: minor fix

4b73d19

test: minor tweaks to EM examples

6193382

test: minor fix to EM examples

1ff3e70

test: improve some EM integration test

c1f940a

Check are the created resource IDs in the results of the list operations.

padamstx approved these changes Apr 13, 2021

View reviewed changes

Merge remote-tracking branch 'origin/main' into update-em

40e6c76

padamstx merged commit 6eaa326 into main Apr 13, 2021

padamstx deleted the update-em branch April 13, 2021 19:07

ibm-devx-sdk added the released label Apr 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(Enterprise Management): update service after recent API changes and add examples #102

fix(Enterprise Management): update service after recent API changes and add examples #102

pyrooka commented Apr 8, 2021 •

edited

Loading

codecov bot commented Apr 8, 2021 •

edited

Loading

padamstx Apr 9, 2021

padamstx Apr 9, 2021

padamstx Apr 9, 2021

padamstx Apr 9, 2021

padamstx Apr 9, 2021

padamstx Apr 9, 2021

padamstx Apr 9, 2021

padamstx Apr 9, 2021

padamstx Apr 9, 2021

padamstx Apr 9, 2021

CLAassistant commented Apr 12, 2021 •

edited

Loading

padamstx Apr 12, 2021

ibm-devx-sdk commented Apr 13, 2021

	second_account_group_id = None
	new_parent_account_group_id = None

	first_account_group_id = create_account_group_response.get('account_group_id')
	account_group_id = create_account_group_response.get('account_group_id')

	name=updated_enterprise_name,
	name='Updated Example Enterprise',

	results_count += 1
	results_count += list_account_groups_response.get('rows_count')

	name='Updated Enterprise Name',
	name='Updated Example Enterprise',

fix(Enterprise Management): update service after recent API changes and add examples #102

fix(Enterprise Management): update service after recent API changes and add examples #102

Conversation

pyrooka commented Apr 8, 2021 • edited Loading

PR summary

PR Checklist

Current vs new behavior

Does this PR introduce a breaking change?

Other information

codecov bot commented Apr 8, 2021 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CLAassistant commented Apr 12, 2021 • edited Loading

Choose a reason for hiding this comment

ibm-devx-sdk commented Apr 13, 2021

pyrooka commented Apr 8, 2021 •

edited

Loading

codecov bot commented Apr 8, 2021 •

edited

Loading

CLAassistant commented Apr 12, 2021 •

edited

Loading