Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: example labels #108

Merged
merged 22 commits into from
Apr 21, 2021
Merged

fix: example labels #108

merged 22 commits into from
Apr 21, 2021

Conversation

Andras-Csanyi
Copy link
Contributor

@Andras-Csanyi Andras-Csanyi commented Apr 16, 2021 •
edited
Loading

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Andras-Csanyi Andras-Csanyi self-assigned this Apr 16, 2021
@CLAassistant
Copy link

CLAassistant commented Apr 16, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 16, 2021 •
edited
Loading

Codecov Report

Merging #108 (31d0bea) into main (92d5465) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #108   +/-   ##
=======================================
  Coverage   93.65%   93.65%           
=======================================
  Files          22       22           
  Lines       20644    20645    +1     
=======================================
+ Hits        19335    19336    +1     
  Misses       1309     1309
Impacted Files Coverage Δ
ibm_platform_services/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92d5465...31d0bea. Read the comment docs.

padamstx
padamstx approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor changes needed, but I'll approve now assuming those are addressed.

examples/test_global_catalog_v1_examples.py Show resolved Hide resolved
examples/test_global_catalog_v1_examples.py Show resolved Hide resolved
examples/test_global_catalog_v1_examples.py Show resolved Hide resolved
examples/test_global_catalog_v1_examples.py Show resolved Hide resolved
examples/test_global_catalog_v1_examples.py Show resolved Hide resolved
@padamstx padamstx merged commit 9ef08e4 into main Apr 21, 2021
@padamstx padamstx deleted the fix-example-labels branch April 21, 2021 20:16
ibm-devx-sdk pushed a commit that referenced this pull request Apr 21, 2021
@semantic-release-bot
chore(release): 0.18.8 release notes
0c5206a 
## [0.18.8](v0.18.7...v0.18.8) (2021-04-21)

### Bug Fixes

* update __init__.py and working examples ([#108](#108)) ([9ef08e4](9ef08e4))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.18.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

@pyrooka pyrooka pyrooka approved these changes

Assignees

@Andras-Csanyi Andras-Csanyi

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Andras-Csanyi @CLAassistant @ibm-devx-sdk @pyrooka @padamstx