Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(IAM Identity): update service after recent API changes #109

Merged
merged 4 commits into from
Apr 26, 2021
Merged

fix(IAM Identity): update service after recent API changes #109

merged 4 commits into from
Apr 26, 2021

Conversation

pyrooka
Copy link
Member

@pyrooka pyrooka commented Apr 22, 2021

PR summary

This PR contains the re-generated IAM Identity service and the updated integration tests.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@codecov
Copy link

codecov bot commented Apr 22, 2021 •
edited
Loading

Codecov Report

Merging #109 (e7e9a14) into main (9ef08e4) will decrease coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   93.65%   93.65%   -0.01%     
==========================================
  Files          22       22              
  Lines       20645    20651       +6     
==========================================
+ Hits        19336    19341       +5     
- Misses       1309     1310       +1
Impacted Files Coverage Δ
ibm_platform_services/iam_identity_v1.py 93.31% <83.33%> (-0.07%) ⬇️
ibm_platform_services/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fce5a5...e7e9a14. Read the comment docs.

@pyrooka pyrooka requested a review from padamstx April 22, 2021 14:58
@padamstx padamstx self-assigned this Apr 26, 2021
padamstx
padamstx approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 92bcda0 into main Apr 26, 2021
@padamstx padamstx deleted the update-iam branch April 26, 2021 15:52
ibm-devx-sdk pushed a commit that referenced this pull request Apr 26, 2021
@semantic-release-bot
chore(release): 0.18.9 release notes
a3f32ae 
## [0.18.9](v0.18.8...v0.18.9) (2021-04-26)

### Bug Fixes

* **IAM Identity:** update service after recent API changes ([#109](#109)) ([92bcda0](92bcda0))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.18.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pyrooka @ibm-devx-sdk @padamstx