Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceController service update #165

Merged
merged 4 commits into from
Jul 29, 2022
Merged

ResourceController service update #165

merged 4 commits into from
Jul 29, 2022

Conversation

apoorva9s14
Copy link
Contributor

Signed-off-by: apoorva9s14 apoorvalaiti16@gmail.com

PR summary

For the resource controller service update as per this PR - https://github.ibm.com/cloud-api-docs/resource-controller/pull/244, resource-controller-v2.yaml is the updated yaml, I have regenerated the SDK files with openapi-sdkgen.
We are looking to address:

Looping - https://github.ibm.com/cloud-api-docs/resource-controller/issues/226
Credentials redaction

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • [ Yes] The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • [ Yes] Docs have been added / updated (for bug fixes / features)

Current vs new behavior

The examples and the SDK code snippet in the apidocs would be updated for credentials redaction

Does this PR introduce a breaking change?

  • Yes
  • [. ] No

Other information

Signed-off-by: apoorva9s14 <apoorvalaiti16@gmail.com>
Signed-off-by: apoorva9s14 <apoorvalaiti16@gmail.com>
Signed-off-by: apoorva9s14 <apoorvalaiti16@gmail.com>
Signed-off-by: apoorva9s14 <apoorvalaiti16@gmail.com>
@apoorva9s14 apoorva9s14 requested a review from dpopp07 July 28, 2022 18:11
@CLAassistant
Copy link

CLAassistant commented Jul 28, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@dpopp07 dpopp07 merged commit 13f3a59 into main Jul 29, 2022
@dpopp07 dpopp07 deleted the rc_fix branch July 29, 2022 14:10
ibm-devx-sdk pushed a commit that referenced this pull request Jul 29, 2022
# [0.26.0](v0.25.0...v0.26.0) (2022-07-29)

### Features

* **Resource Controller:** regen to add `cancel_lastop_resource_instance` method ([#165](#165)) ([13f3a59](13f3a59))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.26.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants