Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Global Catalog): re-generate service from latest API definition #18

Merged
merged 2 commits into from
May 7, 2020
Merged

fix(Global Catalog): re-generate service from latest API definition #18

merged 2 commits into from
May 7, 2020

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented May 6, 2020 •
edited
Loading

PR summary

This PR contains a re-generation of the Global Catalog service using the most recent version of the API definition.

Fixes:

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@padamstx padamstx requested a review from dubee May 6, 2020 20:15
@codecov
Copy link

codecov bot commented May 6, 2020 •
edited
Loading

Codecov Report

Merging #18 into master will increase coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   93.87%   94.15%   +0.27%     
==========================================
  Files           7        7              
  Lines        4067     4158      +91     
==========================================
+ Hits         3818     3915      +97     
+ Misses        249      243       -6
Impacted Files Coverage Δ
ibm_platform_services/global_catalog_v1.py 94.58% <ø> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c7d6c4...e12d4ed. Read the comment docs.

@padamstx padamstx merged commit 7edfbe3 into master May 7, 2020
@padamstx padamstx deleted the regen-gc branch May 7, 2020 12:18
ibm-devx-automation pushed a commit that referenced this pull request May 7, 2020
@semantic-release-bot
chore(release): 0.3.3 release notes
c1cac55 
## [0.3.3](v0.3.2...v0.3.3) (2020-05-07)

### Bug Fixes

* **Global Catalog:** re-generate service from latest API definition ([#18](#18)) ([7edfbe3](7edfbe3))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.3.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@padamstx padamstx self-assigned this May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dubee dubee dubee approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@padamstx @ibm-devx-automation @dubee