Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IAM Policy Management): Add support for policy templates #203

Merged
merged 11 commits into from
Sep 5, 2023

Conversation

swcolley
Copy link
Contributor

PR summary

Added feature support for Enterprise IAM work, policy templates and get template assigments.

Issue: https://github.ibm.com/IAM/AM-issues/issues/1346

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

SDK adopters will be able to call policy template and assignment APIs.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

API defintion:
Staging
Prod

Test Information
Integration Tests:

platform-services-python-sdk % pytest test/integration/test_iam_policy_management_v1.py
============================================================================================== test session starts ===============================================================================================
platform darwin -- Python 3.10.8, pytest-7.2.0, pluggy-1.0.0
rootdir: /Users/shaunsmacibm/Desktop/cloud-platform/iam/sdk/platform-services-python-sdk
plugins: cov-2.12.1
collected 26 items                                                                                                                                                                                               

test/integration/test_iam_policy_management_v1.py ..........................                                                                                                                               [100%]

============================================================================================== 26 passed in 10.71s ===============================================================================================

examples tests:

platform-services-python-sdk % pytest examples/test_iam_policy_management_v1_examples.py
============================================================================================== test session starts ===============================================================================================
platform darwin -- Python 3.10.8, pytest-7.2.0, pluggy-1.0.0
rootdir: /Users/shaunsmacibm/Desktop/cloud-platform/iam/sdk/platform-services-python-sdk
plugins: cov-2.12.1
collected 27 items                                                                                                                                                                                               

examples/test_iam_policy_management_v1_examples.py ...........................                                                                                                                             [100%]

=============================================================================================== 27 passed in 6.64s ===============================================================================================

swcolley added 2 commits May 22, 2023 16:59
Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
@padamstx padamstx self-requested a review May 25, 2023 20:31
@padamstx padamstx self-assigned this May 25, 2023
…lates starting with SDKPython

Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
@swcolley
Copy link
Contributor Author

Latest integration tests after change:

pytest test/integration/test_iam_policy_management_v1.py
============================================================================================== test session starts ===============================================================================================
platform darwin -- Python 3.10.8, pytest-7.2.0, pluggy-1.0.0
rootdir: /Users/shaunsmacibm/Desktop/cloud-platform/iam/sdk/platform-services-python-sdk
plugins: cov-2.12.1
collected 26 items                                                                                                                                                                                               

test/integration/test_iam_policy_management_v1.py ..........................                                                                                                                               [100%]

============================================================================================== 26 passed in 13.26s ===============================================================================================

@swcolley swcolley marked this pull request as ready for review May 26, 2023 16:17
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving as the code looks fine (functional) as is. However, I'll just repeat my comment as in the other PRs... i.e. we need to update the API definition with links and example values to improve the generation of int tests and examples.

@@ -49,6 +49,10 @@
example_policy_etag = None
example_custom_role_id = None
example_custom_role_etag = None
example_template_id = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments here re: links & example values as in the other PRs.

@CLAassistant
Copy link

CLAassistant commented Jun 28, 2023

CLA assistant check
All committers have signed the CLA.

@padamstx padamstx merged commit c9df540 into main Sep 5, 2023
@padamstx padamstx deleted the policy-template branch September 5, 2023 16:45
ibm-devx-sdk pushed a commit that referenced this pull request Sep 5, 2023
# [0.41.0](v0.40.2...v0.41.0) (2023-09-05)

### Features

* **IAM Policy Management:** add support for policy templates ([#203](#203)) ([c9df540](c9df540))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.41.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants