Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (IAM Access Groups): Add support for access group templates #212

Merged
merged 1 commit into from
Aug 22, 2023
Merged

feat (IAM Access Groups): Add support for access group templates #212

merged 1 commit into from
Aug 22, 2023

Conversation

hariarla
Copy link
Contributor

@hariarla hariarla commented Jul 19, 2023 •
edited
Loading

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

SDK adopters will be able to call access group template and assignment APIs.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

API Definition
Stage
Production

Integration Tests:
Screenshot 2023-07-19 at 8 57 02 PM

Example Tests
Screenshot 2023-07-19 at 9 08 20 PM

@hariarla hariarla force-pushed the enable_template_operations branch 2 times, most recently from f82ca19 to 0e2a08d Compare July 19, 2023 15:56
@padamstx padamstx self-assigned this Jul 19, 2023
@padamstx padamstx self-requested a review July 19, 2023 21:50
padamstx
padamstx requested changes Jul 20, 2023
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall... just one minor change to use the production service URL

ibm_platform_services/iam_access_groups_v2.py Outdated Show resolved Hide resolved
@hariarla hariarla force-pushed the enable_template_operations branch from 0e2a08d to c50a992 Compare July 20, 2023 15:23
padamstx
padamstx approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

padamstx
padamstx requested changes Jul 24, 2023
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I initially reviewed this PR, I missed the duplicate code examples for the get_template_version operation. You can have only 1 code example per operation.

examples/test_iam_access_groups_v2_examples.py Outdated Show resolved Hide resolved
@hariarla
Copy link
Contributor Author

Unit Tests:
Screenshot 2023-07-25 at 12 02 24 AM

Integration Tests:
Screenshot 2023-07-25 at 12 06 53 AM

Example Tests:
Screenshot 2023-07-25 at 12 31 18 AM

@hariarla hariarla force-pushed the enable_template_operations branch from c50a992 to 3ab29ab Compare July 24, 2023 19:02
@padamstx padamstx assigned pyrooka and unassigned padamstx Jul 25, 2023
@padamstx padamstx requested a review from pyrooka July 25, 2023 13:15
pyrooka
pyrooka requested changes Jul 27, 2023
View reviewed changes
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good, please fix that one small issue.

examples/test_iam_access_groups_v2_examples.py Show resolved Hide resolved
@padamstx padamstx assigned padamstx and unassigned pyrooka Aug 7, 2023
padamstx
padamstx approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hariarla hariarla force-pushed the enable_template_operations branch from 3ab29ab to 0865bfb Compare August 20, 2023 17:44
@hariarla
feat (IAM Access Groups): Add support for access group templates
ad501b6 
Signed-off-by: HARI K ARLA <hariarla@in.ibm.com>
@hariarla hariarla force-pushed the enable_template_operations branch from 0865bfb to ad501b6 Compare August 20, 2023 17:47
@hariarla
Copy link
Contributor Author

Minor changes to schemas.
Tests:
Screenshot 2023-08-20 at 11 07 40 PM
Screenshot 2023-08-20 at 11 01 54 PM
Screenshot 2023-08-18 at 7 26 03 PM

@padamstx padamstx merged commit 2aef015 into main Aug 22, 2023
@padamstx padamstx deleted the enable_template_operations branch August 22, 2023 13:39
ibm-devx-sdk pushed a commit that referenced this pull request Aug 22, 2023
@semantic-release-bot
chore(release): 0.40.0 release notes
208c113 
# [0.40.0](v0.39.0...v0.40.0) (2023-08-22)

### Features

* **IAM Access Groups:** add support for access group templates ([#212](#212)) ([2aef015](2aef015))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.40.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyrooka pyrooka pyrooka requested changes

@padamstx padamstx padamstx approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hariarla @ibm-devx-sdk @pyrooka @padamstx