Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Partner Usage Reports): add new service to project #242

Merged
merged 9 commits into from
Feb 16, 2024

Conversation

manukm-ibm
Copy link
Member

@manukm-ibm manukm-ibm commented Feb 12, 2024

PR summary

Adding new partner API to fetch resource usage reports.
TRI: https://github.ibm.com/BSS/architecture/blob/master/design-docs/cosell/partner.md
Issue: https://github.ibm.com/BSS/metering-deliverables/issues/2063

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

manukm-ibm and others added 5 commits January 23, 2024 12:53
…artner

Signed-off-by: manu.k.m <manu.k.m@ibm.com>
… examples

Signed-off-by: manu.k.m <manu.k.m@ibm.com>
Signed-off-by: manu.k.m <manu.k.m@ibm.com>
Signed-off-by: manu.k.m <manu.k.m@ibm.com>
@manukm-ibm
Copy link
Member Author

Integration test results
Screenshot 2024-01-23 at 12 52 40 PM
Examples result
Screenshot 2024-01-23 at 12 52 51 PM

Signed-off-by: manu.k.m <manu.k.m@ibm.com>
Signed-off-by: manu.k.m <manu.k.m@ibm.com>
@padamstx padamstx changed the title feat(Partner Usage Reports): add partner resource usage report service to Partner usage reports feat(Partner Usage Reports): add new service to project Feb 15, 2024
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to make sure the apidocs URL is correct.

README.md Show resolved Hide resolved
@padamstx padamstx self-assigned this Feb 16, 2024
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit ec17f48 into IBM:main Feb 16, 2024
3 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Feb 16, 2024
# [0.51.0](v0.50.0...v0.51.0) (2024-02-16)

### Features

* **Partner Usage Reports:** add new service to project ([#242](#242)) ([ec17f48](ec17f48))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.51.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants