Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove pytest-depends from project #27

Merged
merged 3 commits into from
May 20, 2020
Merged

fix: remove pytest-depends from project #27

merged 3 commits into from
May 20, 2020

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented May 20, 2020

PR summary

This PR removes the "pytest-depends" dependency from the project as a way to fix the
test method ordering issue discovered after the recent addition of this to the project.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #27 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   93.43%   93.43%           
=======================================
  Files           9        9           
  Lines        5681     5681           
=======================================
  Hits         5308     5308           
  Misses        373      373           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 250756c...4890fe7. Read the comment docs.

@padamstx padamstx merged commit aa5f109 into master May 20, 2020
ibm-devx-automation pushed a commit that referenced this pull request May 20, 2020
# [0.5.0](v0.4.2...v0.5.0) (2020-05-20)

### Bug Fixes

* remove pytest-depends from project ([#27](#27)) ([aa5f109](aa5f109))

### Features

* **Case Management:** add service to project ([#22](#22)) ([250756c](250756c))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@padamstx padamstx deleted the fix-it-ordering branch May 28, 2020 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants