Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(User Management): re-gen service and update tests after API changes #62

Merged
merged 1 commit into from
Nov 30, 2020

Conversation

padamstx
Copy link
Member

PR summary

This PR contains a re-gen of the User Management service plus updates to the integration tests after recent API changes.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@padamstx padamstx self-assigned this Nov 29, 2020
@codecov
Copy link

codecov bot commented Nov 29, 2020

Codecov Report

Merging #62 (ecffddb) into master (26a9e5f) will decrease coverage by 0.02%.
The diff coverage is 92.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   93.65%   93.63%   -0.03%     
==========================================
  Files          19       19              
  Lines       18924    18989      +65     
==========================================
+ Hits        17724    17781      +57     
- Misses       1200     1208       +8     
Impacted Files Coverage Δ
ibm_platform_services/user_management_v1.py 93.24% <92.52%> (-0.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26a9e5f...ecffddb. Read the comment docs.

@padamstx padamstx merged commit 2d799ad into master Nov 30, 2020
@padamstx padamstx deleted the fix-usermgmt branch November 30, 2020 23:36
ibm-devx-automation pushed a commit that referenced this pull request Nov 30, 2020
## [0.15.5](v0.15.4...v0.15.5) (2020-11-30)

### Bug Fixes

* **User Management:** re-gen service and update tests after API changes ([#62](#62)) ([2d799ad](2d799ad))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.15.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants