fix(IAM Policy Management): re-gen service and add examples after recent API changes #79
Conversation
|
@guicabr, this is the Python PR. The examples are in the "example" directory, similar to the node sdk project. |
Codecov Report
@@ Coverage Diff @@
## main #79 +/- ##
==========================================
- Coverage 93.58% 93.57% -0.02%
==========================================
Files 21 21
Lines 19771 19815 +44
==========================================
+ Hits 18503 18542 +39
- Misses 1268 1273 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Looks good. I made one minor suggestion about variable names.
Edit: after pulling the branch and running the examples, I added one more comment related to the print statements. I think it would be good to print out the JSON marshalled form of each response object so we get pretty-printing, etc.
|
|
||
| config = None | ||
|
|
||
| test_account_id = None |
There was a problem hiding this comment.
Because the examples end up as part of the generated reference docs, it might be better to name variables like example_account_id instead of test_account_id. It's a really minor thing, but thought I'd mention it.
| resources=[policy_resource] | ||
| ).get_result() | ||
|
|
||
| print(policy) |
There was a problem hiding this comment.
| print(policy) | |
| print(json.dumps(policy, indent=2)) | |
## [0.17.12](v0.17.11...v0.17.12) (2021-02-25) ### Bug Fixes * **IAM Policy Management:** re-gen service and add examples after recent API changes ([#79](#79)) ([3e92813](3e92813))
|
🎉 This PR is included in version 0.17.12 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR summary
Updates the IAM Policy Management service and adds examples after recent API changes.
PR Checklist
Please make sure that your PR fulfills the following requirements:
PR Type
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change?
Other information