Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Global Catalog): re-gen service and add examples #81

Merged
merged 2 commits into from
Feb 18, 2021
Merged

fix(Global Catalog): re-gen service and add examples #81

merged 2 commits into from
Feb 18, 2021

Conversation

padamstx
Copy link
Member

PR summary

This PR contains a regen of the Global Catalog service and adds working examples to the project.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@padamstx padamstx self-assigned this Feb 17, 2021
@codecov
Copy link

codecov bot commented Feb 17, 2021 •
edited
Loading

Codecov Report

Merging #81 (aad5294) into main (18be5b0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage   93.58%   93.58%           
=======================================
  Files          21       21           
  Lines       19771    19771           
=======================================
  Hits        18503    18503           
  Misses       1268     1268
Impacted Files Coverage Δ
ibm_platform_services/global_catalog_v1.py 94.67% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18be5b0...aad5294. Read the comment docs.

@padamstx padamstx requested a review from pyrooka February 18, 2021 14:37
pyrooka
pyrooka approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 294b0f5 into main Feb 18, 2021
@padamstx padamstx deleted the gc-examples branch February 18, 2021 22:31
ibm-devx-automation pushed a commit that referenced this pull request Feb 18, 2021
@semantic-release-bot
chore(release): 0.17.10 release notes
759c41e 
## [0.17.10](v0.17.9...v0.17.10) (2021-02-18)

### Bug Fixes

* **Global Catalog:** re-gen service and add examples ([#81](#81)) ([294b0f5](294b0f5))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.17.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyrooka pyrooka pyrooka approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@padamstx @ibm-devx-automation @pyrooka