Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Resource Controller): update service after recent API changes #89

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented Mar 5, 2021

PR summary

This PR contains a re-gen of the Resource Controller service and unit test code, along with updates to the integration tests and examples.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #89 (5bf5c25) into main (a193190) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   93.57%   93.59%   +0.02%     
==========================================
  Files          21       21              
  Lines       19815    19888      +73     
==========================================
+ Hits        18542    18615      +73     
  Misses       1273     1273              
Impacted Files Coverage Δ
ibm_platform_services/resource_controller_v2.py 95.96% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a193190...5bf5c25. Read the comment docs.

@padamstx padamstx self-assigned this Mar 5, 2021
@padamstx padamstx merged commit ec3cdea into main Mar 5, 2021
@padamstx padamstx deleted the update-rc branch March 5, 2021 14:47
ibm-devx-automation pushed a commit that referenced this pull request Mar 5, 2021
## [0.17.13](v0.17.12...v0.17.13) (2021-03-05)

### Bug Fixes

* **Resource Controller:** update service after recent API changes ([#89](#89)) ([ec3cdea](ec3cdea))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.17.13 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants