Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Posture Management): add service to project #93

Merged
merged 13 commits into from
Mar 26, 2021
Merged

feat(Posture Management): add service to project #93

merged 13 commits into from
Mar 26, 2021

Conversation

pyrooka
Copy link
Member

@pyrooka pyrooka commented Mar 9, 2021

PR summary

This PR adds the Posture Management service to the project.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pyrooka pyrooka requested a review from padamstx March 9, 2021 16:45
@codecov
Copy link

codecov bot commented Mar 9, 2021 •
edited
Loading

Codecov Report

Merging #93 (797e527) into main (7678c2a) will increase coverage by 0.04%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   93.58%   93.62%   +0.04%     
==========================================
  Files          21       22       +1     
  Lines       20022    20547     +525     
==========================================
+ Hits        18738    19238     +500     
- Misses       1284     1309      +25
Impacted Files Coverage Δ
ibm_platform_services/posture_management_v1.py 95.23% <95.23%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7678c2a...797e527. Read the comment docs.

@pyrooka pyrooka force-pushed the add-posture-management branch from 7c20182 to cd1657f Compare March 24, 2021 20:50
padamstx
padamstx requested changes Mar 25, 2021
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but I think we need to:

  1. Update the project's README.md file to include the new service.
  2. Add labels to the print statements in the examples.

examples/test_posture_management_v1_examples.py Outdated Show resolved Hide resolved
padamstx
padamstx approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit c194fea into main Mar 26, 2021
@padamstx padamstx deleted the add-posture-management branch March 26, 2021 16:02
ibm-devx-automation pushed a commit that referenced this pull request Mar 26, 2021
@semantic-release-bot
chore(release): 0.18.0 release notes
744d08d 
# [0.18.0](v0.17.18...v0.18.0) (2021-03-26)

### Features

* **Posture Management:** add service to project ([#93](#93)) ([c194fea](c194fea))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.18.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pyrooka @ibm-devx-automation @padamstx