Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for adjustable timeout for admission plugin validation #405

Open
jusschwa-ibm opened this issue Jul 7, 2022 · 0 comments
Open

Allow for adjustable timeout for admission plugin validation #405

jusschwa-ibm opened this issue Jul 7, 2022 · 0 comments

Comments

@jusschwa-ibm
Copy link
Contributor

It is common that when I am doing cluster upgrades the portieris pods will be rescheduled but not be all the way ready, so when we try to do an upgrade we will see some error similar to the following:

cannot patch "some-service-443" with kind ServiceEntry: Internal error occurred: admission plugin "ValidatingAdmissionWebhook" failed to complete validation in 13s
...

If we re-run the upgrade, it will pass. But would be nice if I could increase the value of the timeout for the admission plugin validation so that it would at least wait until portieris is ready to respond to requests instead of failing the upgrade. I tried setting timeoutSeconds in the portieris deployment, but that seemed to have no effect.

Describe the solution that you'd like
Be able to configure the timeout for the admission plugin validation from the helm charts.

Describe alternatives you've considered
There aren't any alternatives. I have been instructing to retry the upgrade, but I don't want to have to do this every time we are upgrading clusters.

@jusschwa-ibm jusschwa-ibm changed the title Adjust timeout for webhook admission Allow for adjustable timeout for admission plugin validation Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant