Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which import case is authoritative: Shopify/shopify? #1058

Closed
therealplato opened this issue Feb 21, 2018 · 3 comments
Closed

Which import case is authoritative: Shopify/shopify? #1058

therealplato opened this issue Feb 21, 2018 · 3 comments

Comments

@therealplato
Copy link

While trying to vendor a repo with dep I encountered this:

master: Could not introduce github.com/bsm/sarama-cluster@master due to a case-only variation: it depends on "github.com/Shopify/sarama", but "github.com/shopify/sarama" was already established as the case variant for that project root by depender (root)

This makes sense, dependency github.com/bsm/sarama-cluster wants upper case Shopify and my code is importing lower case shopify.

I encountered similar issues with Sirupsen/sirupsen and it was a pain to resolve.

I suspect my code's lowercase import is wrong but I'd like official confirmation. Can you bless either github.com/Shopify/sarama or github.com/shopify/sarama as an authoritative import path?

@eapache
Copy link
Contributor

eapache commented Feb 21, 2018

I tend to prefer github.com/Shopify/sarama but I don't know if there's any technical way to bless that?

@therealplato
Copy link
Author

Places I looked were readme and issue search for "case", "import"

@eapache
Copy link
Contributor

eapache commented Feb 21, 2018

Well, this ticket should do then :)

@eapache eapache closed this as completed Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants