Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the new ClusterAdmin's CreateTopic has no timeout setting #1124

Closed
dt665m opened this issue Jul 4, 2018 · 1 comment
Closed

the new ClusterAdmin's CreateTopic has no timeout setting #1124

dt665m opened this issue Jul 4, 2018 · 1 comment

Comments

@dt665m
Copy link

dt665m commented Jul 4, 2018

Versions

Please specify real version numbers or git SHAs, not just "Latest" since that changes fairly regularly.
Sarama Version: 46cf3e2
Kafka Version:
Go Version:

Problem Description

ClusterAdmin's CreateTopic does not populate a sensible timeout or require a timeout in the function signature for the CreateTopicsRequest struct, causing a call to this function to always return a timeout error even on success.

I was going to do a quick PR but don't have time to do the dependencies and I'm not sure if people want control of the timeout or a sensible default is sufficient since the ClusterAdmin stuff is new.

@dt665m dt665m closed this as completed Jul 4, 2018
@dt665m
Copy link
Author

dt665m commented Jul 4, 2018

closed, duplicate of #1120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant