PartitionConsumer.Close() behavior mismatch

[greysond]

Apologies if I'm misreading this, but in the docs for the PartitionConsumer, it states that the Close() method will "initiate a shutdown just like AsyncClose, drain the Messages channel, harvest any errors & return them to the caller."

I'm looking at the method here and it doesn't seem to be draining the messages channel.

[greysond]

I can definitely open a PR for this, but I just wanted to make sure I wasn't missing something.

[kjgorman]

This behaviour was removed in #1156 — probably the godoc is just stale.

[harshana-pickme]

This behaviour was removed in #1156 — probably the godoc is just stale.

What is the behaviour now? I'm using 1.27.2, Here's what I observe

1. create a PartitionConsumer in one goroutine.
2. Before it starts reading the input channel, another goroutine call PartitionConsumer.Close() (due to quick rebalancing of another group consumer)
3. When the first goroutine reaches the code which reads the channel ("for" loop), I'm expecting it to terminate as the ParitionConsumer is now closed. But it does not terminate or read from channel. It gets stuck there forever.

Please enlighten us on this behaviour.
How can I close the channel after closing the PartitionConsumer ?

[ghost]

Thank you for taking the time to raise this issue. However, it has not had any activity on it in the past 90 days and will be closed in 30 days if no updates occur.
Please check if the master branch has already resolved the issue since it was raised. If you believe the issue is still valid and you would like input from the maintainers then please comment to ask for it to be reviewed.