Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to most recent timm #148

Open
CarlosGomes98 opened this issue Sep 5, 2024 · 3 comments
Open

Upgrade to most recent timm #148

CarlosGomes98 opened this issue Sep 5, 2024 · 3 comments
Assignees
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request

Comments

@CarlosGomes98
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
We are currently stuck at an older version of timm. This is a dependency we inherit from torchgeo, which in turn inherits it from smp. SMP is supposedly working towards using a newer version of timm.
Describe the solution you'd like
We don't really have any tight dependency on smp (we now have a way to support their decoders, but could potentially rework this). We should consider upgrading timm.

This enables some new features, for example, easier ways to directly get intermediate features from backbones, which should make onboarding new backbones much easier.

It might take some refactoring of the models we have registered with timm, but it is probably worth it in the long run

@CarlosGomes98 CarlosGomes98 added enhancement New feature or request dependencies Pull requests that update a dependency file labels Sep 5, 2024
@Joao-L-S-Almeida Joao-L-S-Almeida self-assigned this Sep 10, 2024
@Joao-L-S-Almeida
Copy link
Member

Two questions:

  • timm is not explicitly required in requirements/, is that indirectly installed by torchgeo or other ?
  • From the most recent tests, I saw that Actions has installed version 0.9.2, should we move to 1.0.* ?

@CarlosGomes98
Copy link
Collaborator Author

  • It should be pulled in by torchgeo, but we may want to make that explicit and pull it ourselves
  • Im not sure what you mean here :/

@Joao-L-S-Almeida
Copy link
Member

@CarlosGomes98 I asked about explicitly updating timm to versions as 1.0.8 or 1.0.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants