Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exec.sh-cleanup #36

Open
Doeme opened this issue Oct 4, 2019 · 2 comments
Open

exec.sh-cleanup #36

Doeme opened this issue Oct 4, 2019 · 2 comments

Comments

@Doeme
Copy link
Member

Doeme commented Oct 4, 2019

There are certain operations inside exec.sh that should go into a script-file, i.e. the ensure_dir for the non-stemgentoo type environments (

if [ "$2" == "initialize" -a "$MACHINETYPE" != "stemgentoo" ]
)

@TheChymera
Copy link
Member

why would this need to be modular?

@Doeme
Copy link
Member Author

Doeme commented Oct 5, 2019

Because it is modular? This is a initialize/default specific, so it should reside there. I can't think of a reason why it needs to be done in the exec.sh, except that the .gentoo-path ($1) is only visible by the exec.sh-script, but this would imho be better addressed via a configuration variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants