Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heatmap Top K #456

Open
PaulJonasJost opened this issue Feb 6, 2025 · 2 comments
Open

Heatmap Top K #456

PaulJonasJost opened this issue Feb 6, 2025 · 2 comments

Comments

@PaulJonasJost
Copy link
Collaborator

also Related: Single gene Visualization test (=SGV)

If we choose the top K by log fold change this might still be feasible but for significance, we should probably require the sig ana to have run the comparison?
In SGV we use t-test and should perhaps notify people that this pvalue is different to the pvalue from e.g. deseq

@LeaSeep
Copy link
Collaborator

LeaSeep commented Feb 6, 2025

  • fine for me to notify user to first run SigAna however we state that the modules work independent from each other & can be done in arbitrary order which would be then slightly violated. Still , would agree to require user to first run stat. analysis if one wants to have top k based on pvalue. To then not only have LFC as choice for Top k we could also have top varying (based on sd) as option
    -SGV - agree should notify

@PaulJonasJost
Copy link
Collaborator Author

Future trumpets on

If we have outsourced the sigana functions and other functions enough, we can also trigger a significance analysis from the heatmap server that does this, saves it in res_tmp$Sig_Ana and then uses it 🙈

Yes could have some additional choices here. Based on SD sounds good. Will for now only add a warning if the comparison has not been done yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants