Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PETSc Wrapper Explicit Time Variable Bug #130

Closed
eslickj opened this issue Dec 15, 2021 · 1 comment
Closed

PETSc Wrapper Explicit Time Variable Bug #130

eslickj opened this issue Dec 15, 2021 · 1 comment
Assignees
@eslickj

Comments

@eslickj
Copy link
Member

eslickj commented Dec 15, 2021

The PETSc wrapper have a bug where the index of the time variable was aggined an index of -1 if there was no explicit time variable, but when the wrapper went to set the value of the time variable, it checked if the index was > 0. This means that if the index of the time variable happened to be 0, the value of time wouldn't get written to the variable. Need to update to >= 0.
@eslickj eslickj self-assigned this Dec 15, 2021
@eslickj
Copy link
Member Author

eslickj commented Dec 15, 2021

Fixed in #129.

@eslickj eslickj closed this as completed Dec 15, 2021
@eslickj eslickj mentioned this issue Dec 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eslickj eslickj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eslickj