Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helmholtz EoS solver tolerance and diagnostic options. #230

Open
eslickj opened this issue Nov 4, 2022 · 0 comments
Open

Add Helmholtz EoS solver tolerance and diagnostic options. #230

eslickj opened this issue Nov 4, 2022 · 0 comments
Assignees
Labels
Priority:Normal Normal Priority Issue or PR

Comments

@eslickj
Copy link
Member

eslickj commented Nov 4, 2022

We should add solver options (tolerance and max iterations) to the component parameter files. We should also add an option that turns on some diagnostic output, like how many iterations were required for each solve. Currently the parameters are hard coded, but I'm worried they could vary from machine to machine. This would at least allow us to investigate more and tune things. If tolerances are too tight solvers may hit the iteration limit. While not a disaster, it is a big waste of time.

Aside from the saturation density and pressure calculations, all other solves have been migrated to Halley's method from Boost https://www.boost.org/doc/libs/1_80_0/libs/math/doc/html/math_toolkit/roots_deriv.html.

@eslickj eslickj self-assigned this Nov 4, 2022
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Nov 10, 2022
@eslickj eslickj changed the title Next release add Helmholtz EoS solver tolerance and diagnostic options. Add Helmholtz EoS solver tolerance and diagnostic options. Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

No branches or pull requests

2 participants